From 5ed66b911b961acca31a8400c64f405864682b93 Mon Sep 17 00:00:00 2001
From: Sebastian <s.boeckelmann3@gmail.com>
Date: Sun, 29 Oct 2023 07:03:56 +0100
Subject: [PATCH 1/2] Allow missing start and deadline dates when creating
 tasks

---
 backend/.idea/workspace.xml                            | 10 ++++------
 .../timemanager/taskgroup/RecursiveTaskgroupInfo.java  |  2 +-
 .../api/models/timemanager/tasks/TaskEntityInfo.java   |  4 +++-
 .../api/models/timemanager/tasks/TaskOverviewInfo.java |  4 +++-
 .../src/app/tasks/task-editor/task-editor.component.ts |  6 ++++--
 5 files changed, 15 insertions(+), 11 deletions(-)

diff --git a/backend/.idea/workspace.xml b/backend/.idea/workspace.xml
index c0cb9cd..e0758ba 100644
--- a/backend/.idea/workspace.xml
+++ b/backend/.idea/workspace.xml
@@ -5,12 +5,8 @@
   </component>
   <component name="ChangeListManager">
     <list default="true" id="3a869f59-290a-4ab2-b036-a878ce801bc4" name="Changes" comment="Load worked minutes when reloading dashboard">
-      <change afterPath="$PROJECT_DIR$/src/main/java/core/api/models/timemanager/taskSchedule/ScheduleStatus.java" afterDir="false" />
       <change beforePath="$PROJECT_DIR$/.idea/workspace.xml" beforeDir="false" afterPath="$PROJECT_DIR$/.idea/workspace.xml" afterDir="false" />
-      <change beforePath="$PROJECT_DIR$/src/main/java/core/api/controller/ScheduleController.java" beforeDir="false" afterPath="$PROJECT_DIR$/src/main/java/core/api/controller/ScheduleController.java" afterDir="false" />
-      <change beforePath="$PROJECT_DIR$/src/main/java/core/api/models/timemanager/taskSchedule/ActiveMinutesInformation.java" beforeDir="false" />
-      <change beforePath="$PROJECT_DIR$/src/main/java/core/repositories/timemanager/BasicTaskScheduleRepository.java" beforeDir="false" afterPath="$PROJECT_DIR$/src/main/java/core/repositories/timemanager/BasicTaskScheduleRepository.java" afterDir="false" />
-      <change beforePath="$PROJECT_DIR$/src/main/java/core/services/TaskScheduleService.java" beforeDir="false" afterPath="$PROJECT_DIR$/src/main/java/core/services/TaskScheduleService.java" afterDir="false" />
+      <change beforePath="$PROJECT_DIR$/src/main/java/core/api/models/timemanager/tasks/TaskEntityInfo.java" beforeDir="false" afterPath="$PROJECT_DIR$/src/main/java/core/api/models/timemanager/tasks/TaskEntityInfo.java" afterDir="false" />
     </list>
     <option name="SHOW_DIALOG" value="false" />
     <option name="HIGHLIGHT_CONFLICTS" value="true" />
@@ -107,7 +103,9 @@
       <workItem from="1698298897364" duration="4242000" />
       <workItem from="1698426430946" duration="665000" />
       <workItem from="1698474363766" duration="3686000" />
-      <workItem from="1698499063683" duration="7685000" />
+      <workItem from="1698499063683" duration="8312000" />
+      <workItem from="1698557538577" duration="18000" />
+      <workItem from="1698557567325" duration="862000" />
     </task>
     <task id="LOCAL-00001" summary="Structure Taskgroups in Hierarchies">
       <option name="closed" value="true" />
diff --git a/backend/src/main/java/core/api/models/timemanager/taskgroup/RecursiveTaskgroupInfo.java b/backend/src/main/java/core/api/models/timemanager/taskgroup/RecursiveTaskgroupInfo.java
index 2cfd127..3e5e8e5 100644
--- a/backend/src/main/java/core/api/models/timemanager/taskgroup/RecursiveTaskgroupInfo.java
+++ b/backend/src/main/java/core/api/models/timemanager/taskgroup/RecursiveTaskgroupInfo.java
@@ -32,7 +32,7 @@ public class RecursiveTaskgroupInfo {
 
         for(Task task : taskgroup.getActiveTasks()) {
             this.activeTasks.add(new TaskOverviewInfo(task));
-            if(task.getDeadline().isBefore(LocalDate.now())) {
+            if(task.getDeadline() != null && task.getDeadline().isBefore(LocalDate.now())) {
                 this.hasOverdueTask = true;
             }
         }
diff --git a/backend/src/main/java/core/api/models/timemanager/tasks/TaskEntityInfo.java b/backend/src/main/java/core/api/models/timemanager/tasks/TaskEntityInfo.java
index 6fb9121..3fcf030 100644
--- a/backend/src/main/java/core/api/models/timemanager/tasks/TaskEntityInfo.java
+++ b/backend/src/main/java/core/api/models/timemanager/tasks/TaskEntityInfo.java
@@ -28,7 +28,9 @@ public class TaskEntityInfo {
         this.eta = task.getEta();
         this.startDate = task.getStartDate();
         this.deadline = task.getDeadline();
-        this.overdue = LocalDate.now().isAfter(task.getDeadline());
+        if(task.getDeadline() != null) {
+            this.overdue = LocalDate.now().isAfter(task.getDeadline());
+        }
         this.finished = task.isFinished();
         this.workTime = task.getWorkTime();
     }
diff --git a/backend/src/main/java/core/api/models/timemanager/tasks/TaskOverviewInfo.java b/backend/src/main/java/core/api/models/timemanager/tasks/TaskOverviewInfo.java
index 22d5dc7..d4d701b 100644
--- a/backend/src/main/java/core/api/models/timemanager/tasks/TaskOverviewInfo.java
+++ b/backend/src/main/java/core/api/models/timemanager/tasks/TaskOverviewInfo.java
@@ -19,7 +19,9 @@ public class TaskOverviewInfo {
         this.activeMinutes = task.getWorkTime();
         this.eta = task.getEta();
         this.limit = task.getDeadline();
-        this.overdue = LocalDate.now().isAfter(task.getDeadline());
+        if(task.getDeadline() != null) {
+            this.overdue = LocalDate.now().isAfter(task.getDeadline());
+        }
     }
 
     public long getTaskID() {
diff --git a/frontend/src/app/tasks/task-editor/task-editor.component.ts b/frontend/src/app/tasks/task-editor/task-editor.component.ts
index 7c18112..dd5d4c6 100644
--- a/frontend/src/app/tasks/task-editor/task-editor.component.ts
+++ b/frontend/src/app/tasks/task-editor/task-editor.component.ts
@@ -72,11 +72,13 @@ export class TaskEditorComponent implements OnInit {
   }
 
   editTask() {
+    const startingDate = this.startDate.value.length == 0? null:this.startDate.value.length
+    const deadline = this.endDate.value.length == 0? null:this.endDate.value.length
     this.taskService.tasksTaskIDPost(this.editorData.task!.taskID, {
       taskName: this.nameCtrl.value,
       eta: this.etaCtrl.value,
-      startDate: this.startDate.value,
-      deadline: this.endDate.value
+      startDate: startingDate,
+      deadline: deadline
     }).subscribe({
       next: resp => {
         this.editorData.task!.taskName = this.nameCtrl.value;
-- 
2.34.1


From 99880522df6b7142375061114c0f189a51469c8b Mon Sep 17 00:00:00 2001
From: Sebastian <s.boeckelmann3@gmail.com>
Date: Sun, 29 Oct 2023 07:13:08 +0100
Subject: [PATCH 2/2] Check if there is another active schedule when starting
 task now

---
 backend/.idea/workspace.xml                        | 14 ++++++++++++--
 .../java/core/services/TaskScheduleService.java    |  3 ++-
 2 files changed, 14 insertions(+), 3 deletions(-)

diff --git a/backend/.idea/workspace.xml b/backend/.idea/workspace.xml
index e0758ba..c7a54fb 100644
--- a/backend/.idea/workspace.xml
+++ b/backend/.idea/workspace.xml
@@ -6,7 +6,7 @@
   <component name="ChangeListManager">
     <list default="true" id="3a869f59-290a-4ab2-b036-a878ce801bc4" name="Changes" comment="Load worked minutes when reloading dashboard">
       <change beforePath="$PROJECT_DIR$/.idea/workspace.xml" beforeDir="false" afterPath="$PROJECT_DIR$/.idea/workspace.xml" afterDir="false" />
-      <change beforePath="$PROJECT_DIR$/src/main/java/core/api/models/timemanager/tasks/TaskEntityInfo.java" beforeDir="false" afterPath="$PROJECT_DIR$/src/main/java/core/api/models/timemanager/tasks/TaskEntityInfo.java" afterDir="false" />
+      <change beforePath="$PROJECT_DIR$/src/main/java/core/services/TaskScheduleService.java" beforeDir="false" afterPath="$PROJECT_DIR$/src/main/java/core/services/TaskScheduleService.java" afterDir="false" />
     </list>
     <option name="SHOW_DIALOG" value="false" />
     <option name="HIGHLIGHT_CONFLICTS" value="true" />
@@ -105,7 +105,7 @@
       <workItem from="1698474363766" duration="3686000" />
       <workItem from="1698499063683" duration="8312000" />
       <workItem from="1698557538577" duration="18000" />
-      <workItem from="1698557567325" duration="862000" />
+      <workItem from="1698557567325" duration="1724000" />
     </task>
     <task id="LOCAL-00001" summary="Structure Taskgroups in Hierarchies">
       <option name="closed" value="true" />
@@ -269,6 +269,16 @@
           <line>52</line>
           <option name="timeStamp" value="1" />
         </line-breakpoint>
+        <line-breakpoint enabled="true" type="java-line">
+          <url>file://$PROJECT_DIR$/src/main/java/core/services/TaskScheduleService.java</url>
+          <line>86</line>
+          <option name="timeStamp" value="5" />
+        </line-breakpoint>
+        <line-breakpoint enabled="true" type="java-line">
+          <url>file://$PROJECT_DIR$/src/main/java/core/services/TaskScheduleService.java</url>
+          <line>93</line>
+          <option name="timeStamp" value="6" />
+        </line-breakpoint>
       </breakpoints>
     </breakpoint-manager>
   </component>
diff --git a/backend/src/main/java/core/services/TaskScheduleService.java b/backend/src/main/java/core/services/TaskScheduleService.java
index 85562b4..933dca4 100644
--- a/backend/src/main/java/core/services/TaskScheduleService.java
+++ b/backend/src/main/java/core/services/TaskScheduleService.java
@@ -82,7 +82,8 @@ public class TaskScheduleService {
 
     public ServiceResult<BasicTaskSchedule> scheduleTaskNow(Task task) {
         //Check if task has already an active schedule
-        if(task.hasActiveSchedule()) {
+        ServiceResult<BasicTaskSchedule> activeSchedule = getActiveSchedule(task.getTaskgroup().getUser().getUsername());
+        if(task.hasActiveSchedule() || activeSchedule.getExitCode() != ServiceExitCode.MISSING_ENTITY) {
             return new ServiceResult<>(ServiceExitCode.ENTITY_ALREADY_EXIST);
         } else {
             BasicTaskSchedule basicTaskSchedule = new BasicTaskSchedule(task, LocalDate.now());
-- 
2.34.1