Refactoring: Keyboard-Input in GameInputUser verschieben #4

New Issue

sebastian · 2026-04-16T19:33:26Z

sebastian commented

2026-04-16 19:33:26 +00:00

GameLayer::onUpdate() hat zwei Verantwortlichkeiten die nichts miteinander zu tun haben: Input und Spielsimulation.
3a: Keyboard-Input in GameInputUser verschieben
Aktuell in GameLayer::onUpdate() (direkt + inkonsistent):

if (InputManager::isKeyPressed(GLFW_KEY_1))
    gameMode->setActiveBuilding(BuildingType::FOREST_HUT);
// ...
if (keyboard->keyPressEvent(GLFW_KEY_U)) { ... }

Stattdessen: GameInputUser bekommt eine Methode processKeyboard():

// GameInputUser.h
struct KeyboardIntent {
    glm::vec3 moveDir = {0,0,0};
    bool nextTurn     = false;
    bool toggleUpgrade = false;
    bool cancelAction  = false;
    std::optional<BuildingType> selectBuilding;
};

KeyboardIntent processKeyboard();

GameLayer::onUpdate() ruft das nur noch ab:

void GameLayer::onUpdate() {
    mousePicker->update(*camera);

    if (gameInputUser->isKeyboardEnabled()) {
        auto intent = gameInputUser->processKeyboard();
        camera->move(intent.moveDir, 0.5f);

        if (intent.selectBuilding)
            gameMode->setActiveBuilding(*intent.selectBuilding);
        if (intent.cancelAction) {
            gameMode->resetActiveBuilding();
            BuildPreviewSystem::disableBuildPreview(*entityManager);
        }
        if (intent.nextTurn)
            turnSystem->nextTurn(*turnState, events);
        if (intent.toggleUpgrade) { /* ... */ }
    }

    worldSystems->update(/* ... */);
}

GameLayer::onUpdate() hat zwei Verantwortlichkeiten die nichts miteinander zu tun haben: Input und Spielsimulation. 3a: Keyboard-Input in GameInputUser verschieben Aktuell in GameLayer::onUpdate() (direkt + inkonsistent): ``` if (InputManager::isKeyPressed(GLFW_KEY_1)) gameMode->setActiveBuilding(BuildingType::FOREST_HUT); // ... if (keyboard->keyPressEvent(GLFW_KEY_U)) { ... } ``` Stattdessen: GameInputUser bekommt eine Methode processKeyboard(): ``` // GameInputUser.h struct KeyboardIntent { glm::vec3 moveDir = {0,0,0}; bool nextTurn = false; bool toggleUpgrade = false; bool cancelAction = false; std::optional<BuildingType> selectBuilding; }; KeyboardIntent processKeyboard(); ``` GameLayer::onUpdate() ruft das nur noch ab: ``` void GameLayer::onUpdate() { mousePicker->update(*camera); if (gameInputUser->isKeyboardEnabled()) { auto intent = gameInputUser->processKeyboard(); camera->move(intent.moveDir, 0.5f); if (intent.selectBuilding) gameMode->setActiveBuilding(*intent.selectBuilding); if (intent.cancelAction) { gameMode->resetActiveBuilding(); BuildPreviewSystem::disableBuildPreview(*entityManager); } if (intent.nextTurn) turnSystem->nextTurn(*turnState, events); if (intent.toggleUpgrade) { /* ... */ } } worldSystems->update(/* ... */); } ```

sebastian added the

refactoring

label 2026-04-16 19:33:26 +00:00

sebastian added the

engine

label 2026-04-16 19:38:36 +00:00

sebastian added this to the Dicewars project 2026-04-16 20:50:41 +00:00

sebastian self-assigned this 2026-04-16 21:04:37 +00:00

sebastian referenced this issue from a commit

2026-04-17 05:09:34 +00:00

UPD: Move Keyboard-Input to GameInputUser, closes #4

sebastian closed this issue